-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary AWS config field alias #1859
Merged
didier-wenzek
merged 1 commit into
thin-edge:main
from
Bravo555:configdto-aws-field-tweak
Mar 30, 2023
Merged
Remove unnecessary AWS config field alias #1859
didier-wenzek
merged 1 commit into
thin-edge:main
from
Bravo555:configdto-aws-field-tweak
Mar 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes unnecessary serde alias for `aws` field in `TEdgeConfigDto` struct. The alias was introduced when merging initial AWS support for version 0.9.0, so the comment was wrong at the time, and the alias was never used, but I missed that during review. Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Bravo555
temporarily deployed
to
Test Pull Request
March 27, 2023 16:39
— with
GitHub Actions
Inactive
Robot Results
Passed Tests
|
PradeepKiruvale
approved these changes
Mar 28, 2023
didier-wenzek
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
rina23q
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha good catch :) I remember the old days. We used azure
instead of az
, therefore added #[serde(default, alias = "azure")]
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit removes unnecessary serde alias for
aws
field inTEdgeConfigDto
struct. The alias was introduced when merging initial AWS support for version 0.9.0, so the comment was wrong at the time, and the alias was never used, but I missed that during review.Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments