-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: always remove/purge if package exists #1866
Merged
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:fix-uninstall-remove-then-purge
Mar 30, 2023
Merged
fix: always remove/purge if package exists #1866
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:fix-uninstall-remove-then-purge
Mar 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A package exists in different states (not just installed), e.g. * installed * installed (but with config errors) * removed (but config files exist) Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
reubenmiller
temporarily deployed
to
Test Pull Request
March 29, 2023 15:28
— with
GitHub Actions
Inactive
PradeepKiruvale
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Robot Results
Passed Tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Reuben Miller reuben.d.miller@gmail.com
Proposed changes
Fixes the assumption that a package must be in the "installed" state before it can be purged. For instance, if the user removes the packages first, then calls again with purge, it previously did not purge the packages. Now it does.
Background:
A package exists in different states (not just installed), e.g.
The uninstall script just checks if the package is in any state of the above states, and will run remove or purge based on the user's preference.
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments