-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test: test_fs_events #1882
Merged
didier-wenzek
merged 2 commits into
thin-edge:main
from
didier-wenzek:fix/test_fs_events
Mar 31, 2023
Merged
Fix flaky test: test_fs_events #1882
didier-wenzek
merged 2 commits into
thin-edge:main
from
didier-wenzek:fix/test_fs_events
Mar 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
didier-wenzek
temporarily deployed
to
Test Pull Request
March 31, 2023 15:18
— with
GitHub Actions
Inactive
rina23q
approved these changes
Mar 31, 2023
Robot Results
Passed Tests
|
Will be fixed or definitly removed by thin-edge#1879 Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
didier-wenzek
had a problem deploying
to
Test Pull Request
March 31, 2023 16:01
— with
GitHub Actions
Failure
didier-wenzek
had a problem deploying
to
Test Pull Request
March 31, 2023 18:58
— with
GitHub Actions
Failure
didier-wenzek
temporarily deployed
to
Test Pull Request
March 31, 2023 19:12
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Temporary fix: wait a bit before updating the file system to give to the watching actor a chance to be ready.
Types of changes
Paste Link to the issue
See #1879
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments