-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test for raising alarms in folder telemetry and move the child de… #1887
Conversation
…vice telemetry test there Signed-off-by: gligorisaev <gligorisaev@gmail.com>
Robot Results
Passed Tests
|
|
||
Send retained Alarm | ||
[Documentation] https://github.com/thin-edge/thin-edge.io/blob/main/docs/src/tutorials/raise-alarm.md | ||
[Arguments] ${folder} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Arguments] ${folder} | |
[Arguments] ${severity} |
Its about the severity
of the alarm. So, better to rename.
#Clearing alarms | ||
Execute Command sudo tedge mqtt pub tedge/alarms/${folder}/temperature_${folder} "" -q 2 -r | ||
Device Should Not Have Alarm/s type=temperature_${folder} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also add a test for the child
devices as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes little sence because it is already existing:
https://github.com/thin-edge/thin-edge.io/blob/main/tests/RobotFramework/tests/child_alarms/c8y_child_alarms_rpi.robot
Signed-off-by: gligorisaev <gligorisaev@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments