-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Azure and Aws mapper using actors #1888
Refactor Azure and Aws mapper using actors #1888
Conversation
Aws mapper actor Signed-off-by: Pradeep Kumar K J <pradeepkumar.kj@softwareag.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This is close to be approved.
pub fn make_valid_topic_or_panic(topic_name: &str) -> Topic { | ||
Topic::new(topic_name).expect("Invalid topic name") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is useless. Use instead Topic::new_unchecked()
that does the same.
4b04f79
to
0d31e56
Compare
Robot Results
Passed Tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
It would be better to remove make_valid_topic_or_panic
(both for AZ and AWS) and to use instead Topic::new_unchecked()
.
pub fn make_valid_topic_or_panic(topic_name: &str) -> Topic { | ||
Topic::new(topic_name).expect("Invalid topic name") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be removed. Use instead Topic::new_unchecked()
that does the same.
c7ce635
to
6bd9106
Compare
Proposed changes
Port the existing azure and aws mappers to actor based mappers
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments