-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add just file support #1889
Add just file support #1889
Conversation
Robot Results
Passed Tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the targets executed form all and every crates? E.g cargo make ziglang
takes 30 s on a machine where zig is already installed. Is this the intended behavior of cargo make
? I find this so annoying that this would prevent me to use it.
Makefile.toml
Outdated
[tasks.clippy] | ||
install_crate = "cargo-clippy" | ||
command = "cargo" | ||
args = ["clippy"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add --all-targets --all-features
to reduce the difference with what is done on the CI workflow.
@Ruadhri17 and @reubenmiller I do think the better is to give up on this task. On a host where the build has already been done, |
After developer feedback, we will be changing the direction from using cargo-make to just. Goals
|
03a0bec
to
56d703b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is really better! And useful!
026185a
to
3467620
Compare
Signed-off-by: Krzysztof Piotrowski <krzysztof.piotrowski@inetum.com> Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Proposed changes
Types of changes
Paste Link to the issue
#1659
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments