-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use transfer dir setting instead of hard-coded path #1898
Merged
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:fix-config-hardcoded-path
Apr 5, 2023
Merged
fix: use transfer dir setting instead of hard-coded path #1898
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:fix-config-hardcoded-path
Apr 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reubenmiller
added
bug
Something isn't working
theme:configuration
Theme: Configuration management
theme:childdevices
Theme: Child device related topics
labels
Apr 4, 2023
reubenmiller
changed the title
fix: use transfer dir setting
fix: use transfer dir setting instead of hard-coded path
Apr 4, 2023
reubenmiller
temporarily deployed
to
Test Pull Request
April 4, 2023 18:27
— with
GitHub Actions
Inactive
Robot Results
Passed Tests
|
didier-wenzek
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
reubenmiller
force-pushed
the
fix-config-hardcoded-path
branch
from
April 5, 2023 09:29
384e5d6
to
e3cbe26
Compare
reubenmiller
temporarily deployed
to
Test Pull Request
April 5, 2023 09:36
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
theme:childdevices
Theme: Child device related topics
theme:configuration
Theme: Configuration management
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Replaced hard-coded
/var/tedge/file-transfer
path with the configured transfer_dir setting.Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments