-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run cargo update
to pass cargo audit
#1925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo-audit` tool in PR check reported a vulnerability in h2 crate, used as a dependency by reqwest and hyper crates, which were in turn used by almost all the crates in our workspace. `cargo update` bumped patch versions of our dependencies, resolving the audit failure. Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Bravo555
changed the title
Run
Run Apr 21, 2023
cargo update
to pass cargo-checkcargo update
to pass cargo audit
Bravo555
temporarily deployed
to
Test Pull Request
April 21, 2023 12:48
— with
GitHub Actions
Inactive
Robot Results
Passed Tests
|
didier-wenzek
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
cargo-audit
tool in PR check reported a vulnerability in h2 crate, used as a dependency by reqwest and hyper crates, which were in turn used by almost all the crates in our workspace.cargo update
bumped patch versions of our dependencies, resolving the audit failure.Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments