-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): use clean session when validating url connectivity during tedge connect #1967
Merged
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:fix-tedge-cli-connect-jwt-check
May 12, 2023
Merged
fix(cli): use clean session when validating url connectivity during tedge connect #1967
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:fix-tedge-cli-connect-jwt-check
May 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edge connect A clean session avoids the problem of receiving older jwt tokens via the local broker from a different c8y.url then the currently configured url Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
PradeepKiruvale
approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
reubenmiller
temporarily deployed
to
Test Pull Request
May 12, 2023 14:12
— with
GitHub Actions
Inactive
Robot Results
Passed Tests
|
reubenmiller
added
bug
Something isn't working
theme:mqtt
Theme: mqtt and mosquitto related topics
theme:c8y
Theme: Cumulocity related topics
labels
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
theme:c8y
Theme: Cumulocity related topics
theme:mqtt
Theme: mqtt and mosquitto related topics
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
A clean session avoids the problem of receiving older jwt tokens via the local broker from a different c8y.url then the currently configured url.
This bug would be most noteable when switching the c8y.url that thin-edge.io connects to.
Switching c8y.urls would result in the following warning message when calling
tedge connect c8y
:Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments