-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Await for a shutdown request when a restart is triggered #1968
Merged
didier-wenzek
merged 2 commits into
thin-edge:main
from
didier-wenzek:improve/restart-actor
May 12, 2023
Merged
Await for a shutdown request when a restart is triggered #1968
didier-wenzek
merged 2 commits into
thin-edge:main
from
didier-wenzek:improve/restart-actor
May 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The restart actor must specifically await a shutdown request to check that the restart has been successfully triggered without consuming subsequent requests. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
didier-wenzek
temporarily deployed
to
Test Pull Request
May 12, 2023 15:44
— with
GitHub Actions
Inactive
rina23q
reviewed
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a question
Robot Results
Passed Tests
|
When an error occures, the RestartManagerActor manager must not give up but return a proper error message the end user. The only exception to that rule is when the actor fails to send messages to its peers. Then logging the last error and giving up is the only way to go. Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
didier-wenzek
temporarily deployed
to
Test Pull Request
May 12, 2023 17:49
— with
GitHub Actions
Inactive
rina23q
approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The restart actor must specifically await a shutdown request to check that the restart has been successfully triggered without consuming subsequent requests.
Proposed changes
Use the
recv_signal()
method instead of therecv_message
method. The former consumes only runtime requests while the latter primary purpose is to consume regular messages (while being alerted of any high-priority signal sent by the runtime).Types of changes
Paste Link to the issue
#1964
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments