-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shutdown a server actor on ^C #1979
Merged
didier-wenzek
merged 1 commit into
thin-edge:main
from
didier-wenzek:fix/shutdown-server-actor
May 16, 2023
Merged
Shutdown a server actor on ^C #1979
didier-wenzek
merged 1 commit into
thin-edge:main
from
didier-wenzek:fix/shutdown-server-actor
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
didier-wenzek
temporarily deployed
to
Test Pull Request
May 16, 2023 15:19
— with
GitHub Actions
Inactive
PradeepKiruvale
approved these changes
May 16, 2023
Robot Results
Passed Tests
|
rina23q
approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tried the current latest code, which indeed didn't kill the process by Ctrl-C.
Also, tried this PR's code, this kills the process by Ctrl-C 👍
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for #1972 re-introduce the issue #1962. The active loop that was preventing the mapper to shutdown, have been move from on actor to another.
Proposed changes
Let shutdown on ^C all the actors implemented using the
Server
trait.Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments
The correct behavior on shutdown might be specific to each actor implementation. This will be addressed after the 0.11 release.