-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http_ext: Replace request to httpbin with mock #1985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mock is unfortunately HTTP only, so if the intent was to test HTTPS as well, then this PR removes it.
Yes, the point was to test HTTPS connection. But it's okay to removed it as this test is indeed flaky due to its dependency to an external resource.
So okay to merge this PR, once fix the dependency.
The request to httpbin service was failing with a 504 for me, so I replaced it with a mock. Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Robot Results
Passed Tests
|
Merging as this issue was blocking the release pipeline. |
Proposed changes
The request to httpbin service was failing with a 504 for me, so I replaced it with a mock.
The mock is unfortunately HTTP only, so if the intent was to test HTTPS as well, then this PR removes it.
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments