-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update deps to fix failing check on nightly #1994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bravo555
had a problem deploying
to
Test Pull Request
May 29, 2023 17:51
— with
GitHub Actions
Failure
Bravo555
force-pushed
the
deps-bump
branch
2 times, most recently
from
May 30, 2023 07:21
3a2f5c5
to
db73796
Compare
Bravo555
had a problem deploying
to
Test Pull Request
May 30, 2023 07:30
— with
GitHub Actions
Failure
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Bravo555
temporarily deployed
to
Test Pull Request
May 30, 2023 08:10
— with
GitHub Actions
Inactive
didier-wenzek
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Robot Results
Passed Tests
|
One important change: because updating all the deps caused some tests to fail, I've changed it to only upgrade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Compiling crate value-bag, which is used by crate log, fails on nightly. This makes all our CI jobs using nightly fail. Updating it fixed the problem.
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments
If we don't want to update all the dependencies, we could alternatively only updatelog
.Updating all the dependencies caused some tests to fail, so only updating
log
for the time being.