-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ConnectUrl parse error message #2038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous error message was incorrect because there are other reasons for parsing to fail than containing scheme or port, e.g. if the value is empty, resulting in an message: Provided URL: '' contains scheme or port Provided URL should contain only domain, eg: 'subdomain.cumulocity.com'. The new message is now more generic, suggestion in the second line should be sufficient to pinpoint the cause of the error by the user. As a side note, we probably shouln't call that a URL if we only expect some parts of the URL. Domain, address, or host would perhaps be better names. Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Bravo555
temporarily deployed
to
Test Pull Request
June 15, 2023 12:34
— with
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files
|
Robot Results
Passed Tests
|
didier-wenzek
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previous error message was incorrect because there are other reasons for parsing to fail than containing scheme or port, e.g. if the value is empty, resulting in an message:
Provided URL: '' contains scheme or port
Provided URL should contain only domain, eg: 'subdomain.cumulocity.com'.
The new message is now more generic, suggestion in the second line should be sufficient to pinpoint the cause of the error by the user.
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments
As a side note, we probably shouln't call that a URL if we only expect some parts of the URL. Domain, address, or host would perhaps be better names.