-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rust 1.71.0 update-related errors #2072
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Bravo555
temporarily deployed
to
Test Pull Request
July 13, 2023 16:41
— with
GitHub Actions
Inactive
Bravo555
had a problem deploying
to
Test Pull Request
July 13, 2023 17:10
— with
GitHub Actions
Failure
didier-wenzek
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Robot Results
Passed Tests
|
After updating rust to 1.71.0, the way we install cargo-udeps currently results in "missing field `rust_version` in initializer of `NewCrate`" error. Changing our `cargo install` invocation to use a git url to use the latest version, along with including `--locked` option seems to solve the issue. Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Bravo555
changed the title
Fix clippy warnings for rust 1.71.0
Fix Rust 1.71.0 update-related errors
Jul 14, 2023
Bravo555
temporarily deployed
to
Test Pull Request
July 14, 2023 07:42
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments