-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(software): use local http server with rate limiting instead of external resource #2085
Merged
reubenmiller
merged 2 commits into
thin-edge:main
from
reubenmiller:test-improve-software-interrupt-reliability
Jul 25, 2023
Merged
test(software): use local http server with rate limiting instead of external resource #2085
reubenmiller
merged 2 commits into
thin-edge:main
from
reubenmiller:test-improve-software-interrupt-reliability
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reubenmiller
added
ci/cd
Repository management and pipeline topics
theme:testing
labels
Jul 20, 2023
reubenmiller
had a problem deploying
to
Test Pull Request
July 20, 2023 16:50
— with
GitHub Actions
Failure
Robot Results
Passed Tests
|
reubenmiller
had a problem deploying
to
Test Pull Request
July 20, 2023 17:17
— with
GitHub Actions
Failure
reubenmiller
had a problem deploying
to
Test Pull Request
July 20, 2023 17:49
— with
GitHub Actions
Failure
reubenmiller
temporarily deployed
to
Test Pull Request
July 20, 2023 18:38
— with
GitHub Actions
Inactive
reubenmiller
temporarily deployed
to
Test Pull Request
July 20, 2023 19:08
— with
GitHub Actions
Inactive
Bravo555
requested changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only small nits, overall it looks very good
tests/images/debian-systemd/files/http-server/stop-http-server.sh
Outdated
Show resolved
Hide resolved
reubenmiller
had a problem deploying
to
Test Pull Request
July 21, 2023 10:07
— with
GitHub Actions
Failure
Bravo555
approved these changes
Jul 21, 2023
…xternal resource Downloading a test file from external urls is very unreliable and it often caused problems whilst running in the github runner. A local http server offers more control over the download process Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
reubenmiller
force-pushed
the
test-improve-software-interrupt-reliability
branch
from
July 21, 2023 12:09
491cc70
to
6f7198f
Compare
reubenmiller
temporarily deployed
to
Test Pull Request
July 21, 2023 12:17
— with
GitHub Actions
Inactive
Bravo555
requested changes
Jul 21, 2023
…p server Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
reubenmiller
temporarily deployed
to
Test Pull Request
July 21, 2023 13:31
— with
GitHub Actions
Inactive
gligorisaev
approved these changes
Jul 24, 2023
Bravo555
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Downloading a test file from external urls is very unreliable and it often caused problems whilst running on the GitHub runner. A local http server offers more control over the download process.
The solution adds a nginx service to the integration test container which can be started on-demand. The server also creates a dummy test file which can be served via a rate limited endpoint.
Some of the advantages are:
Examples of a failed CI runs due to a failing test "tedge-agent should terminate on SIGINT while downloading file":
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments