-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mark mqtt v1 mapper docs as draft #2090
Merged
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:docs-mark-mqtt-as-draft
Jul 25, 2023
Merged
docs: mark mqtt v1 mapper docs as draft #2090
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:docs-mark-mqtt-as-draft
Jul 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
albinsuresh
approved these changes
Jul 25, 2023
reubenmiller
temporarily deployed
to
Test Pull Request
July 25, 2023 06:38
— with
GitHub Actions
Inactive
Robot Results
Passed Tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Mark the mqtt v1 mapper docs as draft to prevent from appearing in the online docs. The draft flag will be removed once a new release is made.
Since the docs were not previously marked as draft, it was causing a build error as the page was linking to a draft page which resulted in a "broken link" (as draft packages are excluded from the production build).
The following failed PR run demonstrating the error can be found here:
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments