-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(tasks): add clean option to flake finder task #2091
Merged
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:test-flake-finder-task-options
Jul 26, 2023
Merged
test(tasks): add clean option to flake finder task #2091
reubenmiller
merged 1 commit into
thin-edge:main
from
reubenmiller:test-flake-finder-task-options
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
reubenmiller
temporarily deployed
to
Test Pull Request
July 25, 2023 08:17
— with
GitHub Actions
Inactive
Robot Results
Passed Tests
|
gligorisaev
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Usuability improvements to the integration test
flake-finder
task to find flakey integration tests.--clean
option to the integration testflake-finder
task to make it easier to remove existing output folders.Note: The
--clean
option is not set to True by default to avoid accidentally deleting the output folder from a previously flake finder run. This is useful because finding flake tests often requires running all the tests 100 times (which takes hours to run). Preserving the output folder data by default prevents accidental flake finder report loss.Example
Providing
--clean
will delete the output folder if it already exists.invoke flake-finder --suite "Lock File" --iterations 20 --outputdir output_flake_finder --clean
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments