Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tedge init): add missing group permissions on base config_dir #2140

Merged

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Fix/add group permissions on the config dir (e.g. /etc/tedge) creation when calling the tedge init command.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #2140 (4c0eb30) into main (08fb053) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

Additional details and impacted files
Files Changed Coverage Δ
crates/core/tedge/src/cli/init.rs 0.0% <0.0%> (ø)

... and 3 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
247 0 5 247 100

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request August 9, 2023 18:54 — with GitHub Actions Inactive
Copy link
Contributor

@PradeepKiruvale PradeepKiruvale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenmiller reubenmiller merged commit 47e2eb1 into thin-edge:main Aug 14, 2023
18 checks passed
@reubenmiller reubenmiller deleted the fix-tedge-init-folder-permissions branch August 14, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants