tedge legacy health messages are not being republished on the te/ topic with the retained flag

[PradeepKiruvale]

Proposed changes

• Enforce the retain flag when the tedge messages are republished on te topics
• integration tests

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
• Documentation Update (if none of the other choices apply)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2147

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA (in all commits with git commit -s)
• I ran cargo fmt as mentioned in CODING_GUIDELINES
• I used cargo clippy as mentioned in CODING_GUIDELINES
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

[didier-wenzek]

Sorry for being a bit harsh publicly, but I already say it too often: "we must take the time to do things properly" and "by taking shortcuts, we are wasting time".

You ticked "I ran cargo fmt as mentioned in CODING_GUIDELINES".

But: https://github.com/thin-edge/thin-edge.io/actions/runs/5828358977/job/15805958541?pr=2149

Run cargo fmt -- --check
Diff in /home/runner/work/thin-edge.io/thin-edge.io/crates/core/tedge_agent/src/tedge_to_te_converter/converter.rs at line 78:
         alarm.insert("severity".to_string(), severity.into());
         message.topic = te_topic;
         message.payload = serde_json::to_string(&alarm)?.into();
-       let message  = message.with_retain();
+        let message = message.with_retain();
         Ok(vec![message])
     }
 
Diff in /home/runner/work/thin-edge.io/thin-edge.io/crates/core/tedge_agent/src/tedge_to_te_converter/converter.rs at line 112:
             _ => return vec![],
         };
         message.topic = topic;
-        let message  = message.with_retain();
+        let message = message.with_retain();
         vec![message]
     }
 
Error: Process completed with exit code 1.

[codecov]

Codecov Report

Merging #2149 (12c1f3d) into main (317114f) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

❗ Current head 12c1f3d differs from pull request most recent head ed3eda4. Consider uploading reports for the commit ed3eda4 to get more accurate results

Additional details and impacted files

Files Changed	Coverage Δ
...tedge_agent/src/tedge_to_te_converter/converter.rs	85.5% <100.0%> (+0.3%)	⬆️
...ore/tedge_agent/src/tedge_to_te_converter/tests.rs	89.4% <100.0%> (+0.2%)	⬆️

... and 4 files with indirect coverage changes

[github-actions]

Robot Results

✅ Passed	❌ Failed	⏭️ Skipped	Total	Pass %
251	0	5	251	100

[didier-wenzek]

Approved

[reubenmiller]

Please update the tests address the following comments:

• tedge legacy health messages are not being republished on the te/ topic with the retained flag #2149 (comment)
• https://github.com/thin-edge/thin-edge.io/pull/2149/files#r1290939684

[reubenmiller]

Approved, thanks for the changes.

[gligorisaev]

it is good practise to keep the Library entries grouped one after another to avoid confusion