Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev(checks): use zigbuild to run just check task if it is available #2157

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Aug 14, 2023

Proposed changes

Make it easier for users to run the just check by using cargo-zigbuild if available. This allows users using MacOS m1 (aarch64 darwin) to run the code checks without having to build in a linux environment (running just release to build natively on MacOS m1 for LInux is already possible).

If cargo-zigbuild is not installed, then cargo will be used (this is auto detected in the justfile. The user can also override the setting by using:

just CARGO=cargo check

*Other changes

  • Remove deprecated docs tasks for the just file.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller changed the title dev(checks): use zigbuild to run just check task if it is available dev(checks): use zigbuild to run just check and test task if it is available Aug 14, 2023
@reubenmiller reubenmiller changed the title dev(checks): use zigbuild to run just check and test task if it is available dev(checks): use zigbuild to run just check task if it is available Aug 14, 2023
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@didier-wenzek
Copy link
Contributor

This can be the opportunity to remove the deprecated targets:

  • docs:
  • docs-install:

…nning natively on macOS m1

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
tedge documentation has been replaced with https://github.com/thin-edge/tedge-docs

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request August 14, 2023 13:14 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
251 0 5 251 100

@reubenmiller reubenmiller merged commit 1b8d027 into thin-edge:main Aug 14, 2023
16 checks passed
@reubenmiller reubenmiller deleted the dev-tools-using-zigbuild branch August 14, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants