Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update cargo-zigbuild to support ziglang 0.11.0 #2165

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

With the release of cargo-zigbuild 0.17.1, it now supports the latest ziglang version, 0.11.0.

The previous constraint of limiting to ziglang 0.10.1 version has been removed as previous issue with building the musl variants on ziglang 0.11.0 has been resolved.

The display of the ziglang version has also be adapter to also check the python ziglang module if the zig command is not found (purely for debugging purposes).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added ci/cd Repository management and pipeline topics theme:packaging Theme: Packaging and release artefact topics labels Aug 17, 2023
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request August 17, 2023 17:10 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
251 0 5 251 100

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller merged commit ab57a58 into thin-edge:main Aug 18, 2023
16 checks passed
@reubenmiller reubenmiller deleted the build-ziglang-0.11.0 branch August 18, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Repository management and pipeline topics theme:packaging Theme: Packaging and release artefact topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants