Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo audit vulnerabilities: rustls-webpki #2180

Merged

Conversation

didier-wenzek
Copy link
Contributor

https://github.com/thin-edge/thin-edge.io/actions/runs/5941141470/job/16111321664?pr=2169 reports vulnerabilities on

  • rustls-webpki
  • webpki

Proposed changes

  • for rustls-webpki: cargo update except for time and time-macros which require rust 1.67
  • for webpki: there is no fix yet

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Bravo555
Copy link
Contributor

Looks like there's still a problem with cargo check, assert_cmd v2.0.12 can't be built on rust 1.65 (requires at least 1.66)
https://github.com/thin-edge/thin-edge.io/actions/runs/5941664849/job/16112981268?pr=2180

Assuming there would be no other blockers, I would be in favour of bumping MSRV as I believe let ... else support is in 1.66 or 1.67

@didier-wenzek didier-wenzek temporarily deployed to Test Pull Request August 22, 2023 16:58 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
257 0 5 257 100

@didier-wenzek
Copy link
Contributor Author

Assuming there would be no other blockers, I would be in favour of bumping MSRV

I'm okay to bump the MSRV. The question is now: which version?

as I believe let ... else support is in 1.66 or 1.67

let ... else support has been added by 1.65.

@Bravo555
Copy link
Contributor

I'm okay to bump the MSRV. The question is now: which version?

I think we can bump to the smallest version that satisfies updated dependencies as part of this PR, and go from there. Maybe we'll have to do another bump to solve the 2nd vuln, but also shouldn't be a problem. As for Yocto, which was usually the blocker, we now use meta-rust, which has rust 1.71, so we can choose pretty much any version.

@didier-wenzek
Copy link
Contributor Author

Bump MSRV to 1.67

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #2180 (3033549) into main (75127c6) will increase coverage by 0.0%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

❗ Current head 3033549 differs from pull request most recent head 6e16a6f. Consider uploading reports for the commit 6e16a6f to get more accurate results

Additional details and impacted files

see 16 files with indirect coverage changes

@didier-wenzek didier-wenzek temporarily deployed to Test Pull Request August 23, 2023 08:42 — with GitHub Actions Inactive
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@didier-wenzek didier-wenzek force-pushed the fix/cargo-audit-vulnerabilities branch from 3033549 to 6e16a6f Compare August 23, 2023 09:27
@didier-wenzek didier-wenzek temporarily deployed to Test Pull Request August 23, 2023 09:39 — with GitHub Actions Inactive
@didier-wenzek didier-wenzek merged commit 763f0a9 into thin-edge:main Aug 23, 2023
17 of 18 checks passed
@didier-wenzek didier-wenzek deleted the fix/cargo-audit-vulnerabilities branch August 23, 2023 10:59
@Bravo555 Bravo555 mentioned this pull request Aug 23, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants