Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: limit clap version to 4.2.x to prevent MSRV bump to 1.70 #2195

Merged

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Aug 27, 2023

Proposed changes

Limit clap dependency to 4.1.x as anything higher enforces a minimum supported rust version (MSRV) of 1.70 (where as the current MSRV version of the project is 1.67). The version is limited to 4.1.x by using the tilde-requirement syntax.

clap released a new version, 4.4.0, however it seems the dependency within 4.3.x includes a dependency to clap_lex where the bump in MSRV was coupled only with a patch version bump (and not a minor version bump). This causes the 4.3.x versions to automatically pull in the more recent clap_lex package via Rusts default

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Some additional context:

  • issue regarding the bump of the clap_lex package from 0.5.0 -> 0.5.1 which includes a bump in the MSRV
  • The open ticket for a MSRV aware dependency resolver:

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request August 27, 2023 09:11 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #2195 (d80a5b9) into main (4048039) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files

see 13 files with indirect coverage changes

@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
257 0 5 257 100 45m19.561s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller merged commit 763509b into thin-edge:main Aug 27, 2023
17 of 18 checks passed
@reubenmiller reubenmiller deleted the fix-clap-version-requirement branch August 27, 2023 23:23
@@ -50,7 +50,7 @@ c8y_log_manager = { path = "crates/extensions/c8y_log_manager" }
c8y_mapper_ext = { path = "crates/extensions/c8y_mapper_ext" }
camino = "1.1"
certificate = { path = "crates/common/certificate" }
clap = { version = "4.1", features = ["cargo", "derive"] }
clap = { version = "~4.2.0", features = ["cargo", "derive"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants