Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add netcat, netstat, and ping to test image #2232

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Add netcat, netstat, and ping to test image #2232

merged 1 commit into from
Sep 11, 2023

Conversation

Bravo555
Copy link
Contributor

@Bravo555 Bravo555 commented Sep 7, 2023

Proposed changes

Add netcat, netstat, and ping to test image.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@Bravo555
Add netcat, netstat, and ping to test image
dc9e725 
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
@Bravo555 Bravo555 temporarily deployed to Test Pull Request September 7, 2023 14:43 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
267 0 5 267 100 57m59.661s

reubenmiller
reubenmiller approved these changes Sep 10, 2023
View reviewed changes
Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Bravo555 Bravo555 merged commit 03ecbca into thin-edge:main Sep 11, 2023
16 checks passed
@Bravo555 Bravo555 deleted the test-image-add-packages branch September 11, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reubenmiller reubenmiller reubenmiller approved these changes

Assignees
No one assigned
Labels
theme:containers Theme: Containerisation topics theme:developer-exp theme:testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bravo555 @reubenmiller