tedge-mapper-aws prints errors for known non-json mosquitto bridge health status messages

[PradeepKiruvale]

Proposed changes

Ignore health status message coming from the bridge as only json based health messages are supported.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
• Documentation Update (if none of the other choices apply)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2236

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA (in all commits with git commit -s)
• I ran cargo fmt as mentioned in CODING_GUIDELINES
• I used cargo clippy as mentioned in CODING_GUIDELINES
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

[codecov]

Codecov Report

Merging #2247 (350bed3) into main (6e386d1) will increase coverage by 0.0%.
The diff coverage is 70.4%.

Additional details and impacted files

Files Changed	Coverage Δ
crates/extensions/aws_mapper_ext/src/converter.rs	89.8% <55.0%> (+0.7%)	⬆️
crates/core/tedge_api/src/health.rs	74.1% <88.8%> (+2.7%)	⬆️
crates/extensions/az_mapper_ext/src/converter.rs	96.9% <90.9%> (+0.2%)	⬆️

... and 1 file with indirect coverage changes

[reubenmiller]

@PradeepKiruvale Wait, we still want to support tedge health messages, we just have to handle the mosquitto bridge related messages properly (I believe we are just ignoring the bridge messages in the tedge-mapper-c8y) without throwing an error.

[PradeepKiruvale]

@PradeepKiruvale Wait, we still want to support tedge health messages, we just have to handle the mosquitto bridge related messages properly (I believe we are just ignoring the bridge messages in the tedge-mapper-c8y) without throwing an error.

Agree, I have reverted those changes. Now only avoid traslating the bridge status messages

[didier-wenzek]

[Minor] It could be nice to minimize the diff.

Here, one way to do that is to return early when this is a bridge topic.

// Ignore health status message coming from the bridges
if input.topic.name.starts_with("tedge/health") && input.topic.name.ends_with("bridge") {
    return vec![];
}

// ... former code unchanged

[didier-wenzek]

Better to avoid exact matches on a the current list of bridge, as adding a new one would break again this mapper.

[PradeepKiruvale]

fixed, added a function to check the bridge dynamically.

[github-actions]

Robot Results

✅ Passed	❌ Failed	⏭️ Skipped	Total	Pass %	⏱️ Duration
273	0	5	273	100	49m24.758999999s

[didier-wenzek]

Approved