Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): update python version used to publish linux packages #2254

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix(build): update python version used to publish linux packages #2254

merged 1 commit into from
Sep 13, 2023

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Sep 13, 2023 •
edited

Proposed changes

Cloudsmith cli 1.1.0 removed support for python 3.8 (see cli's CHANGELOG) which is used by default in the GitHub runner. Bumping python version used for publishing packages to cloudsmith

Example of the failing jobs:

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller
fix(build): update python version used to publish linux packages
c50afd9 
Cloudsmith cli 1.1.0 removed support for python 3.8 which is used by default in the GitHub runner

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added the ci/cd Repository management and pipeline topics label Sep 13, 2023
@reubenmiller reubenmiller temporarily deployed to Test Pull Request September 13, 2023 06:13 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2254 (c50afd9) into main (2eb30d5) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

see 4 files with indirect coverage changes

@github-actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
273 0 5 273 100 51m43.184s

didier-wenzek
didier-wenzek approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller merged commit 31346c8 into thin-edge:main Sep 13, 2023
18 checks passed
@reubenmiller reubenmiller deleted the fix-publish-workflow-python-3.11 branch September 13, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

Assignees
No one assigned
Labels
ci/cd Repository management and pipeline topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reubenmiller @didier-wenzek