Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check registration of log file request capability #2270

Merged

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Sep 18, 2023

Proposed changes

System test improvements regarding the supported operation

  • Add supported operations check
  • Use auto registration mechanism over manually registration via file creation
  • Add protection against an empty supported operations

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request September 18, 2023 22:26 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
273 0 5 273 100 52m1.978s

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller force-pushed the test-check-log-file-cap-registration branch from 77bf4f1 to 5cd8a63 Compare September 19, 2023 00:40
@reubenmiller reubenmiller changed the title Test-check-log-file-cap-registration test: check log capability registration Sep 19, 2023
@reubenmiller reubenmiller added the theme:troubleshooting Theme: Troubleshooting and remote control label Sep 19, 2023
@reubenmiller reubenmiller changed the title test: check log capability registration test: check log file request capability registration Sep 19, 2023
@reubenmiller reubenmiller changed the title test: check log file request capability registration test: check registration of log file request capability Sep 19, 2023
@reubenmiller reubenmiller temporarily deployed to Test Pull Request September 19, 2023 00:50 — with GitHub Actions Inactive
Copy link
Contributor

@Ruadhri17 Ruadhri17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenmiller reubenmiller merged commit df06f2a into thin-edge:main Sep 19, 2023
16 checks passed
@reubenmiller reubenmiller deleted the test-check-log-file-cap-registration branch September 19, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:testing theme:troubleshooting Theme: Troubleshooting and remote control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants