Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Arc<str> for fields in tedge_config #2325

Merged

Conversation

jarhodes314
Copy link
Contributor

Proposed changes

Add support for Arc<str> in the define_tedge_config! macro.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2259

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jarhodes314 jarhodes314 changed the title Support Arc<str> for fields in tedge_config Support Arc<str> for fields in tedge_config Oct 6, 2023
@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request October 6, 2023 15:24 — with GitHub Actions Inactive
Copy link
Contributor

@Bravo555 Bravo555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
314 0 3 314 100 50m23.395999999s

Copy link
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my very limited understanding of this crate, I don't see anything obviously wrong. Approving based on the usage samples and tests.

@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request October 9, 2023 11:13 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2325 (bac5c42) into main (8e78525) will increase coverage by 0.0%.
Report is 3 commits behind head on main.
The diff coverage is 94.2%.

Additional details and impacted files
Files Coverage Δ
crates/common/tedge_config_macros/impl/src/lib.rs 95.2% <100.0%> (ø)
...rates/common/tedge_config_macros/impl/src/query.rs 95.2% <100.0%> (+1.7%) ⬆️
...common/tedge_config_macros/impl/src/input/parse.rs 39.7% <0.0%> (-0.6%) ⬇️
...mon/tedge_config_macros/impl/src/input/validate.rs 94.3% <94.7%> (+0.2%) ⬆️

... and 18 files with indirect coverage changes

Signed-off-by: James Rhodes <jarhodes314@gmail.com>
@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request October 10, 2023 12:41 — with GitHub Actions Inactive
@jarhodes314 jarhodes314 merged commit decc363 into thin-edge:main Oct 11, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants