Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System test for clearing inventory fragments via twin/ topic #2356

Merged
merged 3 commits into from
Oct 25, 2023
Merged

System test for clearing inventory fragments via twin/ topic #2356

merged 3 commits into from
Oct 25, 2023

Conversation

albinsuresh
Copy link
Contributor

@albinsuresh albinsuresh commented Oct 20, 2023 •
edited

Proposed changes

System test for clearing inventory fragments via twin/ topic

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@albinsuresh albinsuresh temporarily deployed to Test Pull Request October 20, 2023 11:03 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023 •
edited

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
321 0 3 321 100 48m29.407s

@albinsuresh albinsuresh temporarily deployed to Test Pull Request October 20, 2023 13:16 — with GitHub Actions Inactive
@albinsuresh albinsuresh temporarily deployed to Test Pull Request October 25, 2023 06:25 — with GitHub Actions Inactive
reubenmiller
reubenmiller approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@albinsuresh albinsuresh merged commit 9e45d84 into thin-edge:main Oct 25, 2023
16 checks passed
@reubenmiller reubenmiller mentioned this pull request Oct 26, 2023
Merged
11 tasks
@albinsuresh albinsuresh deleted the clear-inventory-fragements-test branch November 8, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reubenmiller reubenmiller reubenmiller approved these changes

@gligorisaev gligorisaev gligorisaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@albinsuresh @reubenmiller @gligorisaev