Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: update tests after latest 0.13.0 release #2406

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Nov 3, 2023

Proposed changes

Updating tests to align with new 0.13.0 release which broken some tests which used the latest official released version.

  • Replace usage of the now deprecated get-thin_edge_io.sh script in place of the newer thin-edge.io/install.sh script (hosted in https://github.com/thin-edge/thin-edge.io-website)
  • Updated assertions which relied on the older clap cli formatting (e.g. USAGE: => Usage:)

Notes:

  • There is still one test which relies on the older get-thin_edge_io.sh script as this script allows installing a specific version but the new version is not (but this is planned)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

get-thin-edge_io.sh has been replaced with thin-edge.io/install.sh and the former will be removed in the future

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
…all script

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2406 (5cf4b1a) into main (49146ba) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files

see 6 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
356 0 3 356 100 1h3m24.897s

@reubenmiller reubenmiller merged commit c4c8a55 into thin-edge:main Nov 3, 2023
18 checks passed
@reubenmiller reubenmiller deleted the update-install-tests branch November 3, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants