Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default(variable = "AutoFlag::Auto") #2407

Conversation

didier-wenzek
Copy link
Contributor

Simple follow up task suggested here #2398 (comment)

Proposed changes

  • Use default(variable = "AutoFlag::Auto") for c8y.bridge.include.local_cleansession
  • Remove impl From<&str> for AutoFlag as no more required.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

This removes the need for `impl From<&str> for AutoFlag`

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2407 (614f472) into main (f2c7c61) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files
Files Coverage Δ
...n/tedge_config/src/tedge_config_cli/models/auto.rs 50.0% <ø> (+3.8%) ⬆️
.../tedge_config/src/tedge_config_cli/tedge_config.rs 82.0% <100.0%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
356 0 3 356 100 1h2m19.757s

Copy link
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failure looks unrelated, hence approving.

@reubenmiller
Copy link
Contributor

The test failure looks unrelated, hence approving.

I re-ran the system tests and also logged the flaky test #2416

@didier-wenzek didier-wenzek merged commit 1373b00 into thin-edge:main Nov 6, 2023
18 checks passed
@didier-wenzek didier-wenzek deleted the improve/add_include_localcleansession_setting branch November 6, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants