Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dev and system test images #2422

Merged

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Nov 6, 2023

Proposed changes

Update dependencies (dev container and system test image):

  • update to Debian 12 (bookworm)
  • install mosquitto >= 2.0.18 as it fixes some bugs with the bridge that thin-edge.io is reliant on
  • bump robotframework-devicelibrary version (for system tests)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Debian bookworm is the current stable release of Debian and has the most up-to-date packages in comparison with other versions such as Buster and Bullseye

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
mosquitto >= 2.0.18 is currently only available from the side repo and it fixes some bugs with the bridge that thin-edge.io is reliant on

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Copy link
Contributor

github-actions bot commented Nov 6, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
356 0 3 356 100 56m26.908s

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller
Copy link
Contributor Author

@albinsuresh I tested out the dev container definition in this image and it built without any errors.

docs/src/contribute/BUILDING.md Show resolved Hide resolved
@reubenmiller reubenmiller merged commit 9b1ce24 into thin-edge:main Nov 7, 2023
16 checks passed
@reubenmiller reubenmiller deleted the chore-update-system-test-image branch November 7, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants