-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable nested child device operation support #2409 #2424
Disable nested child device operation support #2409 #2424
Conversation
Codecov Report
Additional details and impacted files
|
Robot Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks okayish. I would like to decide if I approve or not after @albinsuresh replies to my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a temporary fix, I would approve. I assume that some minor points will be refactored in the following PR.
2a94d86
to
c91524a
Compare
Proposed changes
Disable operation support for:
This is just a temporary fix for #2409 to avoid nested child devices and services from messing up the mapper's
operations
directory, which only supports immediate child devices. A proper fix will be coming in a later PR.Types of changes
Paste Link to the issue
#2409
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments