Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nested child device operation support #2409 #2424

Conversation

albinsuresh
Copy link
Contributor

@albinsuresh albinsuresh commented Nov 6, 2023

Proposed changes

Disable operation support for:

  • nested child devices
  • services on any device

This is just a temporary fix for #2409 to avoid nested child devices and services from messing up the mapper's operations directory, which only supports immediate child devices. A proper fix will be coming in a later PR.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2409

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #2424 (2a94d86) into main (23e71d9) will increase coverage by 0.0%.
The diff coverage is 85.6%.

❗ Current head 2a94d86 differs from pull request most recent head c91524a. Consider uploading reports for the commit c91524a to get more accurate results

Additional details and impacted files
Files Coverage Δ
...extensions/c8y_mapper_ext/src/config_operations.rs 87.4% <ø> (+0.1%) ⬆️
crates/extensions/c8y_mapper_ext/src/error.rs 0.0% <ø> (ø)
crates/extensions/c8y_mapper_ext/src/converter.rs 80.9% <85.6%> (+0.5%) ⬆️

... and 7 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
356 0 3 356 100 1h9m8.281s

Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks okayish. I would like to decide if I approve or not after @albinsuresh replies to my comments.

Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a temporary fix, I would approve. I assume that some minor points will be refactored in the following PR.

@albinsuresh albinsuresh force-pushed the bug/2409/nested-child-device-op-support branch from 2a94d86 to c91524a Compare November 7, 2023 10:46
@albinsuresh albinsuresh merged commit 8404726 into thin-edge:main Nov 7, 2023
16 checks passed
@albinsuresh albinsuresh deleted the bug/2409/nested-child-device-op-support branch November 8, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants