Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove git dependency for ws_stream_tungstenite #2442

Merged

Conversation

jarhodes314
Copy link
Contributor

Proposed changes

Now najamelan/ws_stream_tungstenite#13 is resolved, we can move back to a published version of ws_stream_tungstenite

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2202

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Contributor

github-actions bot commented Nov 10, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
358 0 3 358 100 1h9m6.099999999s

@Bravo555
Copy link
Contributor

You probably forgot to include Cargo.lock in the PR.

Signed-off-by: James Rhodes <jarhodes314@gmail.com>
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2442 (b513825) into main (71a1f1c) will increase coverage by 0.0%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

see 12 files with indirect coverage changes

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jarhodes314 jarhodes314 merged commit 87cd1a2 into thin-edge:main Nov 13, 2023
18 checks passed
@jarhodes314 jarhodes314 deleted the chore/update-ws-stream-tungstenite branch November 13, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants