Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat! switch to tedge-agent (consolidated service) #2457

Merged
merged 9 commits into from
Dec 5, 2023
Merged

feat! switch to tedge-agent (consolidated service) #2457

merged 9 commits into from
Dec 5, 2023

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Nov 15, 2023 •
edited

Proposed changes

Package the new consolidated tedge-agent binary:

  • use combined tedge-agent functionaity by default
  • remove tedge-log-plugin and tedge-configuration-plugin
  • update system tests

Blocked by

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2433

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller self-assigned this Nov 15, 2023
@reubenmiller reubenmiller added the theme:packaging Theme: Packaging and release artefact topics label Nov 15, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited

Codecov Report

Merging #2457 (aacc232) into main (4cc8506) will increase coverage by 0.0%.
The diff coverage is 14.2%.

Additional details and impacted files
Files Coverage Δ
crates/common/tedge_utils/src/file.rs 67.3% <100.0%> (ø)
crates/core/tedge/src/cli/mod.rs 73.6% <ø> (ø)
crates/core/tedge_agent/src/agent.rs 0.0% <ø> (ø)
crates/core/tedge_watchdog/src/systemd_watchdog.rs 20.7% <ø> (+0.1%) ⬆️
crates/core/tedge/src/main.rs 61.4% <0.0%> (+6.7%) ⬆️
crates/core/tedge_agent/src/main.rs 0.0% <0.0%> (ø)
crates/extensions/tedge_config_manager/src/lib.rs 67.6% <0.0%> (ø)
crates/extensions/tedge_log_manager/src/lib.rs 64.5% <0.0%> (ø)
crates/core/tedge_agent/src/lib.rs 0.0% <0.0%> (ø)

... and 4 files with indirect coverage changes

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
362 0 3 362 100 52m58.350999999s

@albinsuresh albinsuresh mentioned this pull request Nov 22, 2023
Merged
11 tasks
@reubenmiller reubenmiller marked this pull request as ready for review December 3, 2023 19:43
didier-wenzek
didier-wenzek reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two documentation pages have to be updated:

  • references/agent/tedge-log-management.md
  • references/agent/tedge-configuration-management.md

crates/core/tedge_watchdog/src/systemd_watchdog.rs Show resolved Hide resolved
@didier-wenzek
Copy link
Contributor

Two documentation pages have to be updated:

* `references/agent/tedge-log-management.md`

* `references/agent/tedge-configuration-management.md`

Addressed by c59f04b

albinsuresh
albinsuresh approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@albinsuresh albinsuresh left a comment •
edited by reubenmiller

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code/test changes LGTM.

Many docs still have references to the old plugins and updates to those to be addressed in a separate PR. Here are the ones that needs updating:

  1. getting-started.md
  2. tedge-agent.md
  3. operate/c8y/config_management_plugin.md
  4. operate/c8y/tedge_log_management.md
  5. domain-model.md
  6. update_config_paths.md

A new ticket has been created to cover these items: #2503

docs/src/references/agent/tedge-configuration-management.md Outdated Show resolved Hide resolved
docs/src/references/agent/tedge-configuration-management.md Outdated Show resolved Hide resolved
@reubenmiller @didier-wenzek
remove tedge configuration and log plugins
7f01b95 
The functionality from tedge-configuration-plugin and tedge-log-plugin have been merged into tedge-agent to reduce the overall footprint of thin-edge.io

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller @didier-wenzek
disable tedge-agent by default during new installation
b19649b 
Avoid starting the tedge-agent since it can now run either as the main device or a child device, therefore it needs to be avoided to start with the default "main device" setting before the user has had a chance to change the role of the agent.

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller @didier-wenzek
refactor log and configuration tests by switching to tedge-agent
2e7cddf 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller @didier-wenzek
switch to consolidated tedge-agent binary
6d2af25 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller @didier-wenzek
allow tedge group to edit files within directory
c9bdc9a 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
albinsuresh and others added 4 commits December 5, 2023 14:06
@albinsuresh @didier-wenzek
Remove v1 feature gate
38747cf
@albinsuresh @didier-wenzek
Remove config and log plugin handles from tedge multi-call binary
3d6e70c
@reubenmiller @didier-wenzek
remove duplicated test
66f60d3 
The external fts is covered by teh log_operation_child tests

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@didier-wenzek
Update Log/Config operation documentation
aacc232 
These operations are no more provided by plugins to be deployed
indenpendly, by the the tedge agent.

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@reubenmiller reubenmiller merged commit 5a353ce into thin-edge:main Dec 5, 2023
18 checks passed
@reubenmiller reubenmiller deleted the tedge-agent-v1-packaging branch December 5, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didier-wenzek didier-wenzek didier-wenzek left review comments

@albinsuresh albinsuresh albinsuresh approved these changes

Assignees

@reubenmiller reubenmiller

Labels
theme:packaging Theme: Packaging and release artefact topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reubenmiller @didier-wenzek @albinsuresh