Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create aggregated log file in temp dir #2443 #2460

Merged

Conversation

albinsuresh
Copy link
Contributor

@albinsuresh albinsuresh commented Nov 16, 2023

Proposed changes

The temporary aggregated log file created by the log_manager actor will be created at the temp directory instead of the target file directory, to avoid permission issues when the log manager is not running as root.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2443

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #2460 (3f708f2) into main (ccff7ee) will increase coverage by 0.0%.
The diff coverage is 66.6%.

Additional details and impacted files
Files Coverage Δ
crates/common/log_manager/src/log_utils.rs 89.8% <100.0%> (+3.1%) ⬆️
crates/extensions/c8y_log_manager/src/actor.rs 75.6% <100.0%> (+<0.1%) ⬆️
crates/extensions/tedge_log_manager/src/actor.rs 67.2% <100.0%> (+0.1%) ⬆️
crates/core/tedge_agent/src/agent.rs 0.0% <0.0%> (ø)
crates/extensions/tedge_log_manager/src/config.rs 0.0% <0.0%> (ø)
crates/extensions/tedge_log_manager/src/tests.rs 88.7% <81.8%> (-0.4%) ⬇️
plugins/tedge_log_plugin/src/lib.rs 0.0% <0.0%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
362 0 3 362 100 55m35.638999999s

Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albinsuresh albinsuresh merged commit 6fe2820 into thin-edge:main Nov 16, 2023
18 checks passed
@albinsuresh albinsuresh deleted the fix/2443/log-snapshot-in-temp-dir branch November 23, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants