Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs.path location should be explicit rather than implicit #2480

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

PradeepKiruvale
Copy link
Contributor

Proposed changes

Update the default value of log.path to /var/log/tedge.
Use the log.path value as the implicit directory to write the log files. Instead of attaching tedge to it.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2449

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Pradeep Kumar K J <pkj@softwareag.com>
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #2480 (7c2cad4) into main (5259a45) will increase coverage by 0.1%.
Report is 4 commits behind head on main.
The diff coverage is 50.0%.

Additional details and impacted files
Files Coverage Δ
.../tedge_config/src/tedge_config_cli/tedge_config.rs 80.6% <100.0%> (-0.1%) ⬇️
crates/extensions/c8y_log_manager/src/lib.rs 88.7% <100.0%> (ø)
crates/extensions/c8y_mapper_ext/src/converter.rs 81.4% <ø> (+<0.1%) ⬆️
crates/extensions/c8y_mapper_ext/src/tests.rs 91.6% <100.0%> (ø)
crates/core/tedge/src/cli/init.rs 0.0% <0.0%> (ø)
crates/core/tedge_agent/src/agent.rs 0.0% <0.0%> (ø)
...es/core/tedge_agent/src/software_manager/config.rs 34.5% <0.0%> (ø)

... and 10 files with indirect coverage changes

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
379 0 3 379 100 59m10.824s

Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@PradeepKiruvale PradeepKiruvale merged commit fcc552b into thin-edge:main Nov 27, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants