Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config setting to disable auto-registration of entities #2486

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

PradeepKiruvale
Copy link
Contributor

Proposed changes

This PR adds a feature to enable/disable the auto registration of entities.

To enable the auto registration one must use the below command

sudo tedge config set c8y.entity_store.auto_register true

To disable the auto registration one must set the config as below

sudo tedge config set c8y.entity_store.auto_register false

The default value for the c8y.entity_store.auto_register is set to true.i.e the auto registration is enabled by default.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2483

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #2486 (3bca8a7) into main (56eaa9d) will decrease coverage by 0.1%.
The diff coverage is 66.6%.

Additional details and impacted files
Files Coverage Δ
crates/extensions/c8y_mapper_ext/src/error.rs 0.0% <ø> (ø)
crates/extensions/c8y_mapper_ext/src/tests.rs 91.6% <100.0%> (+<0.1%) ⬆️
.../tedge_config/src/tedge_config_cli/tedge_config.rs 80.6% <83.3%> (+<0.1%) ⬆️
crates/extensions/c8y_mapper_ext/src/config.rs 43.3% <50.0%> (+0.1%) ⬆️
crates/extensions/c8y_mapper_ext/src/converter.rs 81.3% <63.6%> (-0.1%) ⬇️

Copy link
Contributor

github-actions bot commented Nov 29, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
380 0 3 380 100 59m58.083999999s

Signed-off-by: Pradeep Kumar K J <pkj@softwareag.com>
@PradeepKiruvale PradeepKiruvale merged commit b216239 into thin-edge:main Nov 29, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants