Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a robot test to cover the case where mapper doesn't supply client cert #2504

Merged

Conversation

jarhodes314
Copy link
Contributor

Proposed changes

In #2474 (comment), I discussed a minor bug with the mapper's handling of operations that I found while writing robot tests. After some investigation including manual testing, I couldn't reproduce the bug, and then discovered that the issue was my understanding of the robot test code. I have now added the corrected test, as well as correcting the negative case (as due to the same misunderstanding, there was an entirely redundant assertion).

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
370 0 3 370 100 57m48.397999999s

Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

… cert

Signed-off-by: James Rhodes <jarhodes314@gmail.com>
@jarhodes314 jarhodes314 force-pushed the test/file-transfer-mapper-no-cert branch from 9604061 to 297c28f Compare December 13, 2023 16:59
@jarhodes314 jarhodes314 merged commit 290c50c into thin-edge:main Dec 13, 2023
16 checks passed
@jarhodes314 jarhodes314 deleted the test/file-transfer-mapper-no-cert branch December 13, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants