Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c8y-mapper: extract operations module #2517

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

Bravo555
Copy link
Contributor

Proposed changes

This is a subset of changes in #2311, where operations code in the c8y mapper was extracted into a module. It should have fewer issues so it can be merged faster, so these changes could be more quickly integrated into other PRs.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2477

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Merging #2517 (e0c1041) into main (751f326) will decrease coverage by 0.5%.
Report is 6 commits behind head on main.
The diff coverage is 68.5%.

Additional details and impacted files
Files Coverage Δ
crates/extensions/c8y_mapper_ext/src/actor.rs 75.0% <ø> (-3.7%) ⬇️
crates/extensions/c8y_mapper_ext/src/converter.rs 81.3% <100.0%> (-0.1%) ⬇️
crates/extensions/c8y_mapper_ext/src/lib.rs 88.8% <ø> (ø)
...s/c8y_mapper_ext/src/operations/firmware_update.rs 86.9% <ø> (ø)
...nsions/c8y_mapper_ext/src/operations/log_upload.rs 87.9% <100.0%> (ø)
crates/extensions/c8y_mapper_ext/src/tests.rs 91.6% <100.0%> (ø)
crates/extensions/c8y_mapper_ext/src/config.rs 43.3% <0.0%> (ø)
...es/extensions/c8y_mapper_ext/src/operations/mod.rs 86.6% <86.6%> (ø)
...s/c8y_mapper_ext/src/operations/config_snapshot.rs 87.7% <87.7%> (ø)
...ons/c8y_mapper_ext/src/operations/config_update.rs 47.6% <47.6%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
367 0 3 367 100 48m49.222999999s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bravo555 Bravo555 merged commit 2935e42 into thin-edge:main Dec 13, 2023
18 checks passed
@Bravo555 Bravo555 deleted the c8y-mapper-operations-module branch December 13, 2023 10:00
PradeepKiruvale pushed a commit to PradeepKiruvale/thin-edge.io that referenced this pull request Dec 13, 2023
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants