Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve container default settings #2519

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Dec 13, 2023

Proposed changes

Improve the container default settings to enable more out of the box functionality without having to specify settings.

  • add default mqtt bind address
  • shorten HTTP client name from tedge-agent to just tedge

The small improvements are from ongoing work to add a single process container demo to https://github.com/thin-edge/tedge-demo-container.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added the theme:containers Theme: Containerisation topics label Dec 13, 2023
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
369 0 3 369 100 50m33.129s

@reubenmiller reubenmiller merged commit d9c1901 into thin-edge:main Dec 14, 2023
16 checks passed
@reubenmiller reubenmiller deleted the feat-improve-default-container-settings branch December 14, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:containers Theme: Containerisation topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants