-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tedge cert renew uses the existing key to create a new certificate #2520
tedge cert renew uses the existing key to create a new certificate #2520
Conversation
5feaf61
to
4537b23
Compare
Codecov Report
Additional details and impacted files
|
Robot Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in a good shape.
4537b23
to
5b5e3cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
21166d8
to
3052f95
Compare
Proposed changes
This PR changes the behaviour of
tedge cert renew
. The work on #2502 defines thatrenew
=remove
+create
, however, as #2512 is created,renew
should reuse the private key and create only a new certificate.At first, I thought I should have changed the robot tests regarding
tedge cert renew
, but I changed my mind. Indeed, the tests pass and they test the validity of the new certificate. So, I decided not to change them.tests/RobotFramework/tests/tedge/tedge_upload_cert.robot
Types of changes
Paste Link to the issue
#2512
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments