Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust the expected return code when user is missing "Tenant manager" admin rights #2529

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

reey
Copy link
Contributor

@reey reey commented Dec 15, 2023

Proposed changes

Improve the instructions about connecting to Cumulocity IoT:

  • Use Forbidden and Unauthorized when referring to 403 and 401 error messages
  • Include detailed description about each of the above errors
  • Include a section of "common errors"
  • Add info that SSO users are not supported

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller
Copy link
Contributor

Thanks, I was also in the middle of some other additional tips, so I will push a few commits of my own to this PR, e.g.

  • notice that user/email is case sensitive
  • add same tips to the additional cert upload page (same tips which are in the c8y getting started section)

@reubenmiller reubenmiller self-requested a review December 15, 2023 11:10
@reubenmiller reubenmiller added the documentation Improvements or additions to documentation label Dec 15, 2023
@reubenmiller
Copy link
Contributor

Thanks @reey for the PR. I just pushes a commit which expands on the common errors reasons and added a screenshot as well of the Cumulocity IoT Global Role which is required.

@reey
Copy link
Contributor Author

reey commented Dec 15, 2023

@reubenmiller maybe also mention that SSO users are not supported?

@reubenmiller
Copy link
Contributor

@reubenmiller maybe also mention that SSO users are not supported?

Do you know how a user can check if they are an SSO user or not?

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
373 0 3 373 100 45m55.936s

@reubenmiller reubenmiller merged commit 71ad70a into thin-edge:main Dec 18, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants