Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong layer of fail-fast #2541

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

rina23q
Copy link
Member

@rina23q rina23q commented Dec 20, 2023

Proposed changes

Fix #2534

Ensured that yml has no longer error by https://github.com/rina23q/thin-edge.io/actions/runs/7273907768

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b24460d) 75.9% compared to head (6ba9aee) 75.9%.

Additional details and impacted files

see 5 files with indirect coverage changes

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
378 0 3 378 100 1h3m22.280999999s

@rina23q rina23q merged commit a9f66cd into thin-edge:main Dec 20, 2023
18 checks passed
@reubenmiller reubenmiller added the ci/cd Repository management and pipeline topics label Dec 20, 2023
@rina23q rina23q deleted the ci/fix-wrong-fail-fast branch December 20, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Repository management and pipeline topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants