Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove tedge-log-plugin and tedge-configuration-plugin references #2554

Merged
merged 3 commits into from
Dec 22, 2023
Merged

docs: remove tedge-log-plugin and tedge-configuration-plugin references #2554

merged 3 commits into from
Dec 22, 2023

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Dec 21, 2023 •
edited

Proposed changes

Remove references to the deprecated tedge-log-plugin and tedge-configuration-plugins. The functionality is now provided by the tedge-agent.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added the documentation Improvements or additions to documentation label Dec 21, 2023
@reubenmiller reubenmiller marked this pull request as ready for review December 21, 2023 15:57
rina23q
rina23q approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reubenmiller
docs: remove reference to tedge-log-plugin and tedge-configuration-pl…
81bf4d6 
…ugin

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller
docs: remove references to tedge-log-plugin
1420ad2 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller
docs: remove references to deprecated tedge-configuration-plugin
7bdbfe7 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller force-pushed the docs-remove-log-config-references branch from 3137168 to 7bdbfe7 Compare December 22, 2023 11:55
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
378 0 3 378 100 54m45.610999999s

@reubenmiller reubenmiller merged commit fc06621 into thin-edge:main Dec 22, 2023
16 checks passed
@reubenmiller reubenmiller deleted the docs-remove-log-config-references branch December 22, 2023 12:34
@reubenmiller reubenmiller mentioned this pull request Jan 2, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rina23q rina23q rina23q approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reubenmiller @rina23q