Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user warning when an invalid custom operation filename is used #2562

Merged

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Add a warning log message when an invalid custom operation filename is encountered to warn the user that the file will be ignored.

This helps users understand why their custom operation definition is not being used. Previously the user would not receive any indication that thin-edge.io was actively ignoring the file.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added theme:plugins Theme: Plugin interfaces or general plugin topics which don't fit in any other themes improvement User value labels Jan 3, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
378 0 3 378 100 1h5m22.369s

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller merged commit fcb4745 into thin-edge:main Jan 3, 2024
16 checks passed
@reubenmiller reubenmiller deleted the feat-invalid-op-name-warning branch January 3, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement User value theme:plugins Theme: Plugin interfaces or general plugin topics which don't fit in any other themes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants