Add refresh-bridges command
#2573
Conversation
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Bravo555
requested review from
didier-wenzek,
albinsuresh,
jarhodes314,
rina23q,
reubenmiller and
a team
as code owners
Codecov ReportAttention:
Additional details and impacted files
|
Robot Results
|
| // XXX: having file name squished together with 20 fields which go into file content is a bit obscure | ||
| pub config_file: String, |
There was a problem hiding this comment.
Fully agree. That said I would not spent too much time refactoring this bridge config. The long-term plan is to implement a direct connection from the mapper to the cloud - removing the need for an external bridge.
| const C8Y_CONFIG_FILENAME: &str = "c8y-bridge.conf"; | ||
| const AZURE_CONFIG_FILENAME: &str = "az-bridge.conf"; | ||
| const AWS_CONFIG_FILENAME: &str = "aws-bridge.conf"; | ||
| use crate::bridge::AWS_CONFIG_FILENAME; | ||
| use crate::bridge::AZURE_CONFIG_FILENAME; | ||
| use crate::bridge::C8Y_CONFIG_FILENAME; |
There was a problem hiding this comment.
The fact that these constants where defined for connect, disconnect and reconnect is yet another sign that this module has rotten overtime.
| // FIXME: what does this magic number mean? | ||
| if token.contains("71") { |
There was a problem hiding this comment.
This is the C8Y smartrest code for a jwt token payload. See comment line 239.
There was a problem hiding this comment.
My bad, didn't notice the comment above, but still I'm inclined to leave that comment as a reminder that IMO we're using cumulocity smartrest codes magic numbers a bit too much, and having names for all of them defined in the c8y_api crate would be better.
tests/RobotFramework/tests/cumulocity/self-update/tedge_self_update.robot
Outdated
Show resolved
Hide resolved
Bravo555
force-pushed
the
fix/2192/mosquitto-bridge-upgrade
branch
from
2d95173
to
81bde11
Compare
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
Bravo555
force-pushed
the
fix/2192/mosquitto-bridge-upgrade
branch
from
81bde11
to
b127b2f
Compare
Bravo555
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Proposed changes
Add a
tedge refresh-bridgescommand which regenerates and overwrites bridge configuration for all active bridges.Types of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments
It was necessary to extract some stuff from
connectmodule, so I did a small refactor in a first commit and the command implementation in the second. I expect there will be some blockers regarding the command itself (naming, and so on), so I could do the first commit as a separate PR.