Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor service tests by removing unnecessary logic #2575

Merged

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Refactor service system tests to remove unnecessary logic in an attempt to make the tests more stable.

The tests are passing reliably when using the instructions in #2423

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
378 0 3 378 100 59m48.642999999s

@reubenmiller reubenmiller changed the title test: refactor test removing unnecessary logic test: refactor service tests by removing unnecessary logic Jan 9, 2024
@reubenmiller reubenmiller added this pull request to the merge queue Jan 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2024
@reubenmiller reubenmiller added this pull request to the merge queue Jan 10, 2024
Merged via the queue into thin-edge:main with commit 2149ba7 Jan 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants