Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: don't configure repos when installing thin-edge.io via local deb packages #2579

Merged
merged 1 commit into from
Jan 10, 2024
Merged

test: don't configure repos when installing thin-edge.io via local deb packages #2579

merged 1 commit into from
Jan 10, 2024

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Configuring the repo is unnecessary when installing via local deb packages and can fail due to connectivity issues when run under the CI.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Example of failed CI run due to the repo configuration failing:

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
378 0 3 378 100 53m27.025s

@reubenmiller
test: don't configure repos when installing thin-edge.io via local de…
c9faf5d 
…b packages

Configuring the repo is unnecessary and can fail due to connectivity issues when run under the CI.

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller force-pushed the test-skip-repo-setup-local-install branch from 515ddc3 to c9faf5d Compare January 10, 2024 10:51
@reubenmiller
Copy link
Contributor Author

reubenmiller commented Jan 10, 2024 •
edited

Rebased from main to fix the flaky system tests.

@reubenmiller reubenmiller added this pull request to the merge queue Jan 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 10, 2024
@reubenmiller reubenmiller added this pull request to the merge queue Jan 10, 2024
Merged via the queue into thin-edge:main with commit 4d5c44a Jan 10, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bravo555 Bravo555 Bravo555 approved these changes

@gligorisaev gligorisaev gligorisaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reubenmiller @Bravo555 @gligorisaev